cforms II User Forum

	Current User: Guest	FAQs

cforms II User Forum Troubleshooting [Bug] – Linefeed RFC Compliance for HTML emails

[Bug] – Linefeed RFC Compliance for HTML emails

Page: 1

Reply to Post

Add a New Topic

Post

Guest

Cybersheep100

8:54 pm March 3, 2009

Quote and Reply

Oliver,

I had a problem (with 10.3) sending emails (as HTML) – my server was rejecting them with error "RECEIVED: 451 See http://pobox.com/~djb/docs/smtplf.html".

Upon examining the email I noted it had LF (\\n) characters and not CRLF (\\r\\n) at the end of the line.

I have successfully resolved the issue by making a few changes to the code – however I'm not sure I have ALL the changes or even whether I have made some unnecessarily (as your code may filter out changes later). These are the correctins I made:

lib_ajax.php lines 371, 413 and 498 change '\\n' to '\\r\\n'

lib_nonajax.php lines 312 and 494 change '\\n' to '\\r\\n'

lib_aux.php lines 167,168,178,179, 187-191, 200, 201 change '\\n' to '\\r\\n'

I am also wondering whether to make changes to lib_nonajax lines 410 and 412? and cforms_phpmailer.php lines 77 and 99?

So my question is:

Which of the changes I have made/identified I actually needed to make to ensure CRLF on all submited emails (as HTML)? Are there any changes I have missed?

_________________________________________________________________

My second question is that when submitting HTML emails you have coded <HTML> and <BODY> tags (and the associated closing tags) in capitals – whereas now xhtml compliance and good practice suggests they should be lowercase i.e. <html> etc. Is this an "email" thing I'm not aware of or just an oversight?

Thanks for reading and I trust we can get these corrected in future versions of your (excellent) plugin,

Cybersheep100

Admin

Oliver

Munich, Germany

posts 6237

7:34 am March 4, 2009

Quote and Reply

re #1: Good catch, thanks for pointing this out. While it's been this way forerever, I agree, in favor of RFC822, it should be CRLF. It'll be fixed in v10.4.

re #2: The DOCTYPE of the HTML part of the email is set to HTML 4 which doesn't differentiate between upper and lower case tags – so <HTML> is technically ok. Going foward I will maintain the DOCTYPE but will revert to lower case tags anyway, I think it looks cleaner :-)

** FAQS ** cforms home page ** donations

Guest

Cybersheep100

8:18 pm March 4, 2009

Quote and Reply

Thanks Oliver!

Glad I could play one tiny part to help improve a fantastic plugin!

Looking forward to 10.4!

Cybersheep100