cforms II User Forum

Registration is currently disabled.
Guest

FAQs

Login form protected by Login LockDown.


Lost password?
Advanced Search

— Forum Scope —

  

— Match —

   

— Forum Options —

    

Wildcard usage:
*  matches any number of characters    %  matches exactly one character

Minimum search word length is 4 characters - maximum search word length is 84 characters

Topic RSS
new <ol> outside fieldset with v5.5?
October 17, 2007
4:54 pm
ctree
Guest

Hello, I've noticed that version 5.5 generates a new ordered list tag — <ol class="cf-ol"/> — before the (single) fieldset of my form, and I'm posting about it here because it impinges on my css styling. Is this really meant to be there? It seems a bit strange to me as it doesn't seem to serve any purpose? To make it a little clearer, the form's xhtml looks like this in firebug:

 

 

<form class="cform">
<ol class="cf-ol"/>
<fieldset class="cf-fs1">
</fieldset>
<fieldset class="cf_hidden">
</fieldset>
<p class="cf-sb">
</p>
</form>

 

 

 

Note: I'm a new user & first time upgrading (from 5.4 to 5.5) and I'm not sure whether this is a new feature or perhaps something wnet wrong with my upgrade? I upgraded like this: 1) backup my form to text file. 2) Manually backup my css style and graphics in /images folder. 3) Deactivate plugin. 4) remove cforms folder from plugin dir and replace with new copy. 5) Move css and graphics back into place. 6) Activate plugin.

 

 

October 17, 2007
5:38 pm
Oliver
Munich, Germany
Admin
Forum Posts: 6400
Member Since:
March 6, 2005
Offline

What's your URL ctree? I'd be helpful to take a quick look at the actual HTML structure…

October 17, 2007
6:05 pm
ctree
Guest

Sorry Oliver, I'm just testing things locally before going live :( the html looks very much the same, as far as I can tell, there's an ordered list tag without content just before the fieldset, whereas previously ordered list tags would show up inside the fieldsets only. The problem with my css stems from the fact that I am using background graphics just like the "dark-rounded" style example, and the ordered list tags are getting styled with the repeat bg graphic, and a bit of that shows up just before the actual form now. I can fix this of course but in case the ordered list tag is actually meant to be there, it would be great if its class attribute would be different from that of the ol's inside the fieldsets. I can email the html output to you if you want, the forum likes to eat my markup..

October 17, 2007
6:53 pm
Oliver
Munich, Germany
Admin
Forum Posts: 6400
Member Since:
March 6, 2005
Offline

(looking at the code) I think I see what the issue is…or the cause for the superfluous, empty <ol> tag. While it doens't hurt the HTML layout per se, it shouldn't be there and seems to be the result of a different fix I applied…the fix will go into v5.6 which will be a bugfix release.

If you'd like to patch it yourself:

change this line in (cforms.php):

if ( !$fieldsetopen && !$ol ) {

to this:

if ( !$fieldsetopen && !$ol && $field_type<>'fieldsetstart') {

October 17, 2007
10:45 pm
ctree
Guest

That did it :) Thanks for the prompt fix!

Forum Timezone: Europe/Berlin

Most Users Ever Online: 959

Currently Online:
43 Guest(s)

Currently Browsing this Page:
1 Guest(s)

Top Posters:

tracedef: 43

mores: 21

Gyrus: 20

frozenwaste: 18

asuffredini: 15

photoworks: 14

Member Stats:

Guest Posters: 3735

Members: 1463

Moderators: 3

Admins: 2

Forum Stats:

Groups: 1

Forums: 4

Topics: 5336

Posts: 18700

Newest Members: juredujmovic, dreamkeeper, rajattyagi, wrokaa, lukass

Moderators: Paul (421), cnymike (8), sonika (95)

Administrators: Oliver (6400), Nicky (3)